Skip to content

Conversation

jkrems
Copy link
Contributor

@jkrems jkrems commented Oct 4, 2024

  1. Move init_test_bed.js to the end of polyfills to ensure it always runs before any of the test chunks.
  2. Add source maps to served files and only add worker-* and chunk-* files if there are any. This is meant to reduce the number of warnings Karma logs. In practice any non-trivial app should have some chunk-* files for their test suite.
  3. If options.main is provided, use that file instead of the default init_test_bed.js.
  4. Add a new test that prevent future regressions with handling of the main option.

@jkrems jkrems added target: minor This PR is targeted for the next minor release action: review The PR is still awaiting reviews from at least one requested reviewer labels Oct 4, 2024
@jkrems jkrems requested a review from clydin October 4, 2024 20:03
@jkrems jkrems added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Oct 7, 2024
@dgp1130 dgp1130 merged commit ab6e19e into angular:main Oct 7, 2024
31 checks passed
@jkrems jkrems deleted the jk-karma-main branch October 9, 2024 18:01
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: @angular-devkit/build-angular target: minor This PR is targeted for the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants